search

bazelbuild / migration-tooling

Migration tools for Bazel
Apache License 2.0
45 stars 30 forks source link

Remove old TODO in code by integrating java8 features into codebase #22

Closed petroseskinder closed 7 years ago

petroseskinder commented 7 years ago

There was a TODO statement lingering in the code base. It asked to replace a portion of the code with a java8 one liner. The fix was a simple usage of java8 streams, so I went ahead and included it.

reviewer: @kchodorow cc: @hhclam

bazel-io commented 7 years ago

Can one of the admins verify this patch?

kchodorow commented 7 years ago

Jenkins, please test this.

kchodorow commented 7 years ago

Okay, well, I have no idea how to set up Jenkins presubmit hooks, unfortunately, so we'll have to wait for @damienmg for that.

damienmg commented 7 years ago

@kchodorow: FYI, you did correctly on ci so the only thing that was left is giving the bot the permission to write on the repot so adding the "robot" team to have write permission to the repo.

See https://bazel-review.googlesource.com/c/11890/5/docs/owner.md for an extensive in-progress doc about that.