Closed petroseskinder closed 7 years ago
Can one of the admins verify this patch?
Good idea. Just a few nits, the java libraries aren't actually used anywhere.
That was a little confusing for me. Is the intended approach to use the java_library or depending directly the maven_jar? I can see how the java_library may be preferably, in that bazel won't try to fetch the java_library as it would the maven_jar.
I was having an issue with adding a new dependency to a
maven_jar
and found it much easier adding a new dependency using the load.bzl format rather than using the old format.I figure it makes more sense to refactor the WORKSPACE to this format, before presenting that issue. That said, something I found particularly awkward/cumbersome was that whenever I wanted to upgrade or add a new dependency, I would have to execute the following command:
Bah!😫 It would be nice if we didn't have to do all that. #20 and Chris's comment in #25.Stripe uses an intermediary yaml file to make upgrading easier.
reviewer: @kchodorow cc: @hhclam