generate_workspace may pull in too much from dependencyManagement section of POMs

bazelbuild / migration-tooling

Migration tools for Bazel

Apache License 2.0

45 stars 30 forks source link

generate_workspace may pull in too much from dependencyManagement section of POMs #43

Closed greggdonovan closed 7 years ago

greggdonovan commented 7 years ago

Running bazel run //generate_workspace -- '--artifact=org.apache.beam:beam-sdks-java-core:2.0.0' took >1hr and generated a >100k bzl file.

If I remove the JARs pulled in via the parent POMs dependencyManagement, the result appears reasonable.

Should generate_workspace pull in every dependency specified in the full set of parent POMs or just use their versions to override the child POMs versions? Or should only a certain set of JARs brought in through dependencyManagement be used?

petroseskinder commented 7 years ago

This issue is being solved here #44.

petroseskinder commented 7 years ago

@kchodorow can you close this as well?

kchodorow commented 7 years ago

Fixes by #44.