bazelbuild / migration-tooling

Migration tools for Bazel
Apache License 2.0
44 stars 30 forks source link

Implement ModelResolver.addRepository(Repository, boolean) correctly. #65

Open jkinkead opened 6 years ago

jkinkead commented 6 years ago

This correctly honors the replace parameter. It was ignored before, which was making it effectively be treated as false.

Per the reference implementation, the single-argument addRepository should not replace (although it wasn't before).

bazel-io commented 6 years ago

Can one of the admins verify this patch?