bazelbuild / migration-tooling

Migration tools for Bazel
Apache License 2.0
44 stars 30 forks source link

Enable custom repositories. #71

Closed mweiden closed 6 years ago

mweiden commented 6 years ago

Enables the specification of custom repositories in the transitive_maven_jar function.

For more, see https://github.com/bazelbuild/migration-tooling/issues/14#issuecomment-338764262

This is my first PR to a bazel project, so this will likely need some code review and guidance to reach master. Thanks in advance!

bazel-io commented 6 years ago

Can one of the admins verify this patch?

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


mweiden commented 6 years ago

@google I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!

wstrange commented 6 years ago

@mweiden Nice.

Dumb question: Can this use ~/.m2/settings.xml to authenticate against a private repo such as Artifactory? Is there a way to specify the settings.xml location?

petroseskinder commented 6 years ago

Can this use ~/.m2/settings.xml to authenticate against a private repo such as Artifactory? Is there a way to specify the settings.xml location?

@wstrange. As it stands, this PR allows one to pass urls to maven mirrors as arguments to generate_workspace. Perhaps, we leave settings.xml functionality (#7) to a separate PR.

mweiden commented 6 years ago

@petroseskinder I don't have tests for this. You're right, they should be added. I will try to work on this on Friday.

mweiden commented 6 years ago

@petroseskinder tests added. 👀 please!

mweiden commented 6 years ago

@petroseskinder I've made all but one of the changes you requested, run the code formatter, and updated the jar. Please see my comments regarding the default version resolver in the last outdated diff. I hope that all this looks good and is ready to merge.