search

bazelbuild / migration-tooling

Migration tools for Bazel
Apache License 2.0
44 stars 30 forks source link

Switch output from System.out to System.err #72

Closed pgr0ss closed 6 years ago

pgr0ss commented 6 years ago

We have tried to start using the new transitive_maven_jar but ran into a weird case. The migration-tooling stuff will regenerate the generate_workspace.bzl on the first bazel command after changing the WORKSPACE. In our case, we ran a bazel query ... | grep thing and noticed that this showed up in the output (breaking our tooling):

Wrote /home/admin/.cache/bazel/_bazel_admin/61e657d6884c63362b8b441914a1bc68/external/dependencies/generate_workspace.bzl

This pull request changes all of the System.out calls to System.err to avoid this kind of issue in the future. I noticed that the deploy jar was checked in, so I ran this as well, but I'm not sure if there is a better process:

bazel build //generate_workspace:generate_workspace_deploy.jar && cp bazel-bin/generate_workspace/generate_workspace_deploy.jar transitive_maven_jar/
bazel-io commented 6 years ago

Can one of the admins verify this patch?

petroseskinder commented 6 years ago

The migration-tooling stuff will regenerate the generate_workspace.bzl on the first bazel command after changing the WORKSPACE.

Good catch.

I noticed that the deploy jar was checked in, so I ran this as well, but I'm not sure if there is a better process.

Outside of hosting the generate_workspace jar somewhere, I don't think there is. The big issue is that we cannot call Bazel from within Bazel. From what I understand that is not a feature that will be supported in the near future.