set Repository ID - Githubissues

nevillelyh commented 6 years ago

Repository checks getId for equality http://grepcode.com/file/repo1.maven.org/maven2/org.apache.maven/maven-model/3.3.3/org/apache/maven/model/RepositoryBase.java#RepositoryBase.equals%28java.lang.Object%29

Without this, the toSet always end up with 1 repo https://github.com/bazelbuild/migration-tooling/pull/76/files#diff-4518b099acd871fca1a03fff14b3df1bL88

bazel-io commented 6 years ago

Can one of the admins verify this patch?

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

nevillelyh commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!

nevillelyh commented 6 years ago

Just realized that this fixes the same thing as #74 but I believe this is a cleaner fix.

nevillelyh commented 6 years ago

Is this still maintained? @kchodorow please take a look maybe?

bazel-io commented 6 years ago

Can one of the admins verify this patch?

ulfjack commented 6 years ago

@aehlig @dslomov

ulfjack commented 6 years ago

I'll merge this if nobody objects in the next two days.

vorburger commented 6 years ago

@ulfjack did you mean "in the next two = 2 or 20 days" ? :smiley_cat:

ulfjack commented 6 years ago

Apparently I can't merge it. :-/

bazelbuild / migration-tooling

set Repository ID #76