Closed silvergasp closed 3 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
CLAs look good, thanks!
ℹ️ Googlers: Go here for more info.
What is the intent behind these? What compiler toolchains will need to use this?
The use case is for targeting cortex-m microcontrollers. Example of existing toolchain. This PR covers the majority of all arm cortex microcontroller architectures. The intent is to shift the silvergasp/bazel-embedded repo to depend on the upstream "platforms" repository rather than this fork.
Example use case includes cross compiling google pigweed.
Thanks for your patience, I have been doing some research on ARM cpus. I think this PR makes sense, but can you add comments to each constraint stating that it's for Cortex-M0, etc?
No worries that's an easy change.
CLAs look good, thanks!
ℹ️ Googlers: Go here for more info.
Okay, #22 is merged, could you update this to master and then I'll merge it?
CLAs look good, thanks!
ℹ️ Googlers: Go here for more info.
Done!
Thanks, starting the merge process now.
This adds platforms cpu constraints for cortex-m targets;