bazelbuild / platforms

Constraint values for specifying platforms and toolchains
Apache License 2.0
108 stars 71 forks source link

Add arm cortex-m platform constraints #11

Closed silvergasp closed 3 years ago

silvergasp commented 4 years ago

This adds platforms cpu constraints for cortex-m targets;

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

silvergasp commented 4 years ago

@googlebot I signed it!

google-cla[bot] commented 3 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

katre commented 3 years ago

What is the intent behind these? What compiler toolchains will need to use this?

silvergasp commented 3 years ago

The use case is for targeting cortex-m microcontrollers. Example of existing toolchain. This PR covers the majority of all arm cortex microcontroller architectures. The intent is to shift the silvergasp/bazel-embedded repo to depend on the upstream "platforms" repository rather than this fork.

Example use case includes cross compiling google pigweed.

katre commented 3 years ago

Thanks for your patience, I have been doing some research on ARM cpus. I think this PR makes sense, but can you add comments to each constraint stating that it's for Cortex-M0, etc?

silvergasp commented 3 years ago

No worries that's an easy change.

google-cla[bot] commented 3 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

katre commented 3 years ago

Okay, #22 is merged, could you update this to master and then I'll merge it?

google-cla[bot] commented 3 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

silvergasp commented 3 years ago

Done!

katre commented 3 years ago

Thanks, starting the merge process now.