search

bazelbuild / platforms

Constraint values for specifying platforms and toolchains
Apache License 2.0
108 stars 71 forks source link

add wasm cpu #12

Closed lizan closed 4 years ago

lizan commented 4 years ago

Signed-off-by: Lizan Zhou lizan@tetrate.io

katre commented 4 years ago

Is wasm a CPU architecture? How is it intended to be used?

gregestren commented 4 years ago

@lizan can you speak more to the concerns expressed in https://github.com/bazelbuild/platforms#adding-a-canonical-constraint-value?

I realize we still need to evolve the process. It's not immediately obvious what belongs in this repo vs. not, and we need clearer agreement on how to even have the right discussions to figure that out.

But the link above is at least a starting point. This is important not just for us (reviewers and PR producer), but anyone else who may ever look at or consider using these.

lizan commented 4 years ago

@katre yes it should be treated as a CPU architecture. Go/Rust and LLVM treat it as an arch.

@gregestren Sure, the wasm32 already defined in rules_rust, 64bit is a future feature so if we don't like, I can remove that. I am working on make this build in proxy-wasm and Envoy WASM integration, this uses cpu value wasm. The bazel C++ Toolchain blog uses asmjs which is quite confusing as well. There should be a canonical constraint settings for this instead of having CPU value defined everywhere.

lizan commented 4 years ago

gently ping?

katre commented 4 years ago

Looking today, sorry again for the delays.

katre commented 4 years ago

Working to merge this now!