search

bazelbuild / platforms

Constraint values for specifying platforms and toolchains
Apache License 2.0
108 stars 71 forks source link

Add QNX as a possible constraint value #6

Closed narendasan closed 4 years ago

narendasan commented 5 years ago

Have been using bazel to compile for QNX, would like to see it as a constraint value.

gregestren commented 5 years ago

Have you had need to use a specific constraint_value for this?

narendasan commented 5 years ago

Currently for my project I am using ccToolchainConfig's for both QNX and Linux (for aarch64). The issue was that build artifacts would clobber each other because of the shared CPU arch. I was hoping the new platforms feature might help. Considering QNX is a reasonably common OS I thought it might be worth including it in the canonical set of platforms.

gregestren commented 5 years ago

The idea absolutely sounds fair!

Since we want to be careful not to explode the set of values too easily (i.e. once they're added we can't easily roll them back), can you prototype the expected fix and verify this solves the problem for you? If so I think that's a concrete call for adding this.

narendasan commented 5 years ago

Sounds good, will update when I have something that works.

katre commented 4 years ago

Merged as 19815c270457359ba79d6c6a57e73ee4288692f5.