search

bazelbuild / platforms

Constraint values for specifying platforms and toolchains
Apache License 2.0
106 stars 70 forks source link

Create a :darwin alias for :osx #60

Closed arrdem closed 1 year ago

arrdem commented 1 year ago

MacOS knows itself as Darwin, as do some ABIs.

$ arch; uname -a
arm64
Darwin PG9JK00XLN.local 22.2.0 Darwin Kernel Version 22.2.0: Fri Nov 11 02:03:51 PST 2022; root:xnu-8792.61.2~4/RELEASE_ARM64_T6000 arm64

Python for instances uses ABI tags like cpython-38m-darwin. It's convenient to be able to refer to the same constraint consistently. This change consists only of the appropriate alias.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

aiuto commented 1 year ago

I'm not in favor of this. The other Apple related OS names are along the lines of the names of the os OS - macos, tvos, watchos. darwin is a kernel, which could be used under different OSes.

This does raise the question of having a distinct OS space. So one would define a macos platform a having both //os:macos and //kernel:darwin. But let's discuss that as a new issue rather than in a PR. I would like to see the case that kernel distinctions matter in other areas. One might argue that gnu_linux is a kernel, while debian is an OS. But that is a big conceptual change for many people.