search

bazelbuild / platforms

Constraint values for specifying platforms and toolchains
Apache License 2.0
108 stars 71 forks source link

Add OS setting for devices with no OS #7

Closed AustinSchuh closed 5 years ago

AustinSchuh commented 5 years ago

We have bazel targets which we cross compile for on bare metal chips. "none" seems to capture this relatively well.

Looks like this got lost somehow when setting up copybara or something.

googlebot commented 5 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

gregestren commented 5 years ago

Could we have a brief comment clarifying the purpose?

AustinSchuh commented 5 years ago

I added a comment. Please take a look.

gregestren commented 5 years ago

Looks like it merged (https://github.com/bazelbuild/platforms/commit/4e6771f8b444d16c69b8d5455915f3de3d475d2d), but through a somewhat klunky path.