search

bazelbuild / rules_android_ndk

Apache License 2.0
32 stars 15 forks source link

Make toolchain registration optional #50

Closed gferon closed 1 year ago

gferon commented 1 year ago

The moment you add the current rules_android_ndk to a workspace, the build breaks if ANDROID_NDK_HOME is not set, because native.register_toolchains is always called implicitly.

One solution is to allow users to opt-in into setting up the repository only (which is what you'd do with bzlmod) and either call register_toolchains themselves, or use --extra_toolchains=@androidndk//:all.

Downside: this breaks the current API and we can either use a different approach, or mention it in some release notes

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gferon commented 1 year ago

Superseded by #51