search

bazelbuild / rules_appengine

AppEngine rules for Bazel
Apache License 2.0
30 stars 51 forks source link

Use full target names #83

Closed anchlovi closed 6 years ago

anchlovi commented 6 years ago

Use package name to create a "full" target name, hence, supporting targets with the same name originating from different packages

pmbethe09 commented 6 years ago

What issue does this fix?

anchlovi commented 6 years ago

With bazel it is easy to have the same jar name for different modules, unlike maven where the jar name is a combination of artifact id, group id and version bazel jar names are set according to the target name

If there is more than one dependency (direct or transitive) the rule will fail to create the link for the 2nd target since a link with the same name already exists

pmbethe09 commented 6 years ago

ok, then for book-keeping, please file an issue which describes the problem. Then indicate that this PR fixes it.

anchlovi commented 6 years ago

Fixes: https://github.com/bazelbuild/rules_appengine/issues/85

ittaiz commented 6 years ago

@pmbethe09 can this be merged?

pmbethe09 commented 6 years ago

LGTM (sorry I was away)

ittaiz commented 6 years ago

thanks!