search

bazelbuild / rules_apple

Bazel rules to build apps for Apple platforms.
Apache License 2.0
512 stars 269 forks source link

Add support for --attachment_lifetime in ios_xctestrun_runner #2347

Closed kapoorlakshya closed 10 months ago

kapoorlakshya commented 11 months ago

Makes SystemAttachmentLifetime and UserAttachmentLifetime configurable in the runner template. Added 2 tests.

Testing

bazel test //test:ios_xctestrun_runner_ui_test 
INFO: Analyzed target //test:ios_xctestrun_runner_ui_test (0 packages loaded, 0 targets configured).
INFO: Found 1 test target...
Target //test:ios_xctestrun_runner_ui_test up-to-date:
  bazel-bin/test/ios_xctestrun_runner_ui_test
INFO: Elapsed time: 149.951s, Critical Path: 149.86s
INFO: 2 processes: 1 internal, 1 darwin-sandbox.
INFO: Build completed successfully, 2 total actions
//test:ios_xctestrun_runner_ui_test                                      PASSED in 149.4s
kapoorlakshya commented 10 months ago

@mattrobmattrob Thanks for a thorough review. I've accepted all your suggestions.