Fix broken builds with Bazel < 6.4.0

bazelbuild / rules_apple

Bazel rules to build apps for Apple platforms.

Apache License 2.0

512 stars 269 forks source link

Fix broken builds with Bazel < 6.4.0 #2386

Closed thii closed 9 months ago

thii commented 9 months ago

Which doesn't have visionos in the platform type API.

keith commented 9 months ago

interestingly bazel 6.x tests pass without this https://github.com/bazelbuild/rules_apple/pull/2380 i guess because it just doesn't hit this path

thii commented 9 months ago

Looks like we're only testing with 7 LTS and 6 LTS which doesn't cover 6.3.x and below.

keith commented 9 months ago

ah yea I forgot we cherry picked this. i guess we could test an older 6.x, although also I think we assume that folks can safely and easily update to the newest of a LTS train so it's less of an issue