search

bazelbuild / rules_apple

Bazel rules to build apps for Apple platforms.
Apache License 2.0
512 stars 269 forks source link

Fix the issue that the thinned dynamic frameworks would be overwritten by strip_bitcode. #2395

Closed xiemotongye closed 9 months ago

xiemotongye commented 9 months ago

Fix https://github.com/bazelbuild/rules_apple/issues/2392

xiemotongye commented 9 months ago

The tests for xcframework arm64e could be passed previously because the strip_bitcode overwrote the thinned binary to a fat binary.

So I think there may be some other issue in xcframework rules for arm64e.

keith commented 9 months ago

looks like the arm64e issue is https://github.com/bazelbuild/apple_support/pull/301

keith commented 9 months ago

thanks for submitting this! I took your fix into https://github.com/bazelbuild/rules_apple/pull/2398 which also fixes the tests, please reopen your issue if it didn't fix this!