search

bazelbuild / rules_apple

Bazel rules to build apps for Apple platforms.
Apache License 2.0
512 stars 269 forks source link

Fix dynamic framework lipo issue #2398

Closed keith closed 9 months ago

keith commented 9 months ago

Previously when a dynamic framework was lipo'd and then bitcode stripped, the bitcode stripping would replace the lipo'd binary and you'd end up with a binary that contained more architectures than were requested.

Fixes https://github.com/bazelbuild/rules_apple/issues/2392

mattrobmattrob commented 9 months ago

Want to do the apple_support bump in a separate change?

keith commented 9 months ago

We can't separate that bump because otherwise the test fails for something that was previously covered up by this bug

mattrobmattrob commented 9 months ago

Good deal, merge away!