search

bazelbuild / rules_apple

Bazel rules to build apps for Apple platforms.
Apache License 2.0
512 stars 269 forks source link

Fix app intents with Xcode 15.3+ #2418

Closed keith closed 4 months ago

keith commented 8 months ago

Depends on https://github.com/bazelbuild/rules_swift/pull/1170

pennig commented 6 months ago

Has the time come at last?

BalestraPatrick commented 5 months ago

Yes, we just need a new rules_swift release I believe depending on when we're happy with the status of the cherry-picks there

brentleyjones commented 4 months ago

@BalestraPatrick can you update this to point to the rules_swift 2.0.0-rc1 release? I'm going to create a release without this change, which is compatible but doesn't require rules_swift 2.0, and then once that is out we can start depending on it in order to merge this?

BalestraPatrick commented 4 months ago

@brentleyjones Updated now. I also pushed a possible fix for one breaking change (target_name related), but there's another breaking change as expected for the symbol graph API which seems to be more involved since we need to switch to using the aspect instead (https://github.com/bazelbuild/rules_apple/issues/2445):

Error: 'struct' value has no field or method 'symbol_graph'
keith commented 4 months ago

@BalestraPatrick looks like this is validated on CI now https://github.com/bazelbuild/rules_apple/issues/2488

BalestraPatrick commented 4 months ago

I left a comment here: https://github.com/bazelbuild/rules_apple/issues/2488#issuecomment-2216991527

But it looks on rules_apple side we also need to fix the docc rules (https://github.com/bazelbuild/rules_apple/pull/2487) in order to bump to rules_swift 2.0.0 which is required for this PR to be merged.

luispadron commented 4 months ago

The failures are due to DocC rules needing to be updated for rules_swift 2.0, thats being done over in: #2487

The intents tests are passing though via:

bazel test //test/starlark_tests:ios_application