Allow .xcprivacy files in infoplists attribute of ios_application

bazelbuild / rules_apple

Bazel rules to build apps for Apple platforms.

Apache License 2.0

512 stars 269 forks source link

Allow .xcprivacy files in infoplists attribute of ios_application #2432

Closed gferon closed 8 months ago

gferon commented 8 months ago

When submitting an app for TestFlight review, we got a new warning regarding missing API declarations (ITMS-91053: Missing API declaration). The easiest way to fulfill this requirement is to use Xcode to create a so-called "App Privacy" file, which is actually a small .plist file.

I'm not sure whether this should also apply to macOS and watchOS bundles, but I'm pretty sure the answer is yes, so it might be a good idea to allow .xcprivacy files on any infoplists attribute.

brentleyjones commented 8 months ago

Are the values inside of a .xcprivacy file supposed to be merged into the root Info.plist? If not, this wouldn't work.

andre-alves commented 8 months ago

AFAIK .xcprivacy files are just regular resources:

apple_resource_group(
    name = "PrivacyManifest",
    resources = ["PrivacyInfo.xcprivacy"],
)

gferon commented 8 months ago

Oh really 🙈 that's... surprising. Looking at the file and not using Xcode I made the wrong assumption. Thanks!