search

bazelbuild / rules_apple

Bazel rules to build apps for Apple platforms.
Apache License 2.0
509 stars 264 forks source link

Update docc rule to support deps and data #2450

Closed luispadron closed 5 months ago

luispadron commented 5 months ago

Updates the .docc aspect to allow both deps and data attributes as providers for the .docc bundle information. Previously, if the rule defined data but had no DocC bundle we'd lose out on any docc bundle information from the deps.

mattrobmattrob commented 5 months ago

Possible to add a test case to cover this scenario?

luispadron commented 5 months ago

Some weird failures on last_green, not sure theyre related as the test i wrote is passing in the other jobs

brentleyjones commented 5 months ago

Failed on a re-run. We should confirm locally that it still fails (on master), and if so, start to bazelisk bisect to see when it broke in bazel.

luispadron commented 5 months ago

CI seems a bit flaky due to simulator issues and i dont have permissions to retry

   Failure Reason: Failed to create SimDeviceSet at path /Users/buildkite/Library/Developer/Xcode/UserData/IB Support/Simulator Devices. You'll want to check the logs in ~/Library/Logs/CoreSimulator to see why creating the SimDeviceSet failed.
            Description: Unable to determine SimDeviceSet for subscriptions, set_path=/Users/buildkite/Library/Developer/Xcode/UserData/IB Support/Simulator Devices
            Underlying Errors:
    Underlying Errors:
                Failure Reason: Allocation or initialization failed.
                Description: Failed to initialize simulator device set.
mattrobmattrob commented 5 months ago

I've retried the job.