bazelbuild / rules_apple

Bazel rules to build apps for Apple platforms.
Apache License 2.0
512 stars 269 forks source link

Fix provider type checking for AppleDynamicFrameworkProvider migration #2453

Closed luispadron closed 6 months ago

luispadron commented 6 months ago

With the move of AppleDynamicFramework provider to Starlark doing something like type(provider) will always return "struct". This is behavior we shouldn't have and is now broken in latest Bazel versions.

This PR updates to use hasattr to approximate the type as long as it has the fields we need.

More info: https://github.com/bazelbuild/bazel/issues/22095