apple_dynamic_framework_import regressions

bazelbuild / rules_apple

Bazel rules to build apps for Apple platforms.

Apache License 2.0

508 stars 261 forks source link

apple_dynamic_framework_import regressions #746

Open brentleyjones opened 4 years ago

brentleyjones commented 4 years ago

4ec36b79fd35633581f5e1eb51c0bc7aac3f6031 regressed apple_dynamic_framework_import in a couple ways:

~Generated provisioning profiles no longer work, since they aren't listed as an input into ImportedDynamicFrameworkProcessor~ Fixed with #856
~ImportedDynamicFrameworkProcessor needs execution_requirements = {"no-sandbox": "1"} when there is a provisioning profile otherwise the sandbox blocks it~ Fixed with #862
When using ipa_processor a framework that is stripped of its code signature is no longer re-signed (in particular for us, when we strip bitcode and Swift symbols from a framework)

liuliu commented 4 years ago

Any ideas how to put up a fix for this other than revert? @nglevin

thii commented 4 years ago

We’ve just hit an error because of this. We renewed our certificate recently, and the imported frameworks weren’t resigned with the new certificate. It makes it an invalid build because the app and the frameworks were signed with different certificates. This seems like a rare case, but it would be nice to be able to opt out of this feature.

brentleyjones commented 4 years ago

@Keith This should stay open. I'll update it to say the first part is fixed.

keith commented 4 years ago

Sorry it auto closed

keith commented 4 years ago

https://github.com/bazelbuild/rules_apple/pull/862

thii commented 4 years ago

@brentleyjones How are you dealing with the third issue?

brentleyjones commented 4 years ago

@thii We stopped stripping symbols as part of our IPA Post Processor. We now strip the symbols before they are imported by Bazel.

thii commented 4 years ago

I see. I have a patch here that while it does not fix the above ipa_post_processor issue, it can eliminate the need of doing bitcode stripping in ipa_post_processor.

brentleyjones commented 4 years ago

Neat. We also did Swift symbols stripping as part of the ipa_post_processor, so that would need to be done (as well, in a different change).