search

bazelbuild / rules_cc

C++ Rules for Bazel
https://bazel.build
Apache License 2.0
182 stars 90 forks source link

pull some missed PRs from gerrit #111

Closed aiuto closed 2 years ago

aiuto commented 3 years ago

Hmmm. The internal review process shows more changes than I would expect. I am not sure that is safe to approve. I need to learn more about that.

On Tue, Aug 17, 2021 at 2:26 PM oquenchil @.***> wrote:

@.**** approved this pull request.

LGTM

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bazelbuild/rules_cc/pull/111#pullrequestreview-732092223, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXHHHC3P7USWU6PMOMLV63T5KSTVANCNFSM5CKL2PCQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

aiuto commented 2 years ago

This does not feel like the right way to get in sync.