search

bazelbuild / rules_cc

C++ Rules for Bazel
https://bazel.build
Apache License 2.0
186 stars 93 forks source link

Switch to libtool_check_unique from bazel #126

Closed keith closed 2 years ago

keith commented 2 years ago

We had to include this file in this repo before a version of bazel was released that included it. It is included with bazel 5.0 at this point, and has received fixes that haven't been ported here. We could continue to duplicate them here, but it doesn't seem like there's a reason to until we try to move things like this out of bazel.

https://github.com/bazelbuild/bazel/commit/48dd159808c5a874c4aabcd27d6e66610d41bb5a

keith commented 2 years ago

This will make this only compatible with bazel 5.x+, if that's not acceptable we can merge https://github.com/bazelbuild/rules_cc/pull/127 instead

keith commented 2 years ago

CI fixes https://github.com/bazelbuild/rules_cc/pull/128

keith commented 2 years ago

dropping for https://github.com/bazelbuild/rules_cc/pull/154