search

bazelbuild / rules_cc

C++ Rules for Bazel
https://bazel.build
Apache License 2.0
181 stars 89 forks source link

Add rule to compile Windows Resources #131

Closed jheaff1 closed 2 years ago

jheaff1 commented 2 years ago

This commit relates to bazelbuild/bazel#8273 and copies the rule from the bazel source tree, as recommended in comment https://github.com/bazelbuild/bazel/issues/8273#issuecomment-571496000

jheaff1 commented 2 years ago

LGTM

Thanks for the review. Is there anything I must to complete the import/copybara task so that this PR can be merged?

oquenchil commented 2 years ago

Nothing to do on your side, but when merging this PR things are breaking internally and I won't be able to look at the problem at this moment.

oquenchil commented 2 years ago

I will ask that you please maintain this rule in your own repo. We'll see if at a later time we merge this or not.

HelcioM commented 2 months ago

I lost track of where I put a comment here. I am trying to use this "https://github.com/bazelbuild/rules_cc/pull/131/files" but bazel cannot find the rule:

ERROR: Traceback (most recent call last): File "C:/users/m3nv1c/bazeltutorial/examples-main/cpp-tutorial/embedresources-master/src/BUILD", line 4, column 46, in load("@rules_cc//cc:defs.bzl", "cc_binary", "windows_resources") Error: file '@rules_cc//cc:defs.bzl' does not contain symbol 'windows_resources'

Could anyone confirm that the change is in current version? Thank you.