search

bazelbuild / rules_cc

C++ Rules for Bazel
https://bazel.build
Apache License 2.0
181 stars 89 forks source link

Find `libtool` when using `BAZEL_USE_CPP_ONLY_TOOLCHAIN`. #135

Closed uri-canva closed 9 months ago

uri-canva commented 2 years ago

Instead of hardcoding /usr/bin/libtool which requires Xcode / Xcode CLT installed, which BAZEL_USE_CPP_ONLY_TOOLCHAIN is meant to avoid.

Related to https://github.com/bazelbuild/rules_cc/issues/134.

oquenchil commented 2 years ago

Hi Uri, this is a nice PR, can you send it to bazelbuild/bazel? This file being repeated is an unfortunate consequence of a flag that we were never able to flip and the source of truth for now is in bazelbuild/bazel.

Thanks!

oquenchil commented 2 years ago

I will LGTM and merge here too.

uri-canva commented 2 years ago

You probably saw it because you mention "here too" but just for reference, I posted it at about the same time: https://github.com/bazelbuild/bazel/pull/16010.

uri-canva commented 2 years ago

When is rules_cc updated from the bazel repo? Is it an automated process on a certain cadence? I ask because I also opened another PR to pull in changes from there: https://github.com/bazelbuild/rules_cc/pull/136, those are already in the bazel repo.