search

bazelbuild / rules_cc

C++ Rules for Bazel
https://bazel.build
Apache License 2.0
181 stars 89 forks source link

Move Apple toolchain setup to apple_support #154

Closed keith closed 1 year ago

keith commented 1 year ago

Mirrors https://github.com/bazelbuild/bazel/pull/16619

keith commented 1 year ago

I think some of the other open PRs removing duplication in this repo will have to land first for this now, something must have changed upstream

keith commented 1 year ago

Merging https://github.com/bazelbuild/rules_cc/pull/163 instead would be ideal, but if that one is blocked for some reason doing this one in the meantime would be fine

oquenchil commented 1 year ago

Hey Keith,

No blockers for now on merging the rest, right now it's just pending reviews internally. I will get all of those merged first.

oquenchil commented 1 year ago

And thank you!

keith commented 1 year ago

Awesome thanks! Can you create a new release somewhere in there so we can update what is in bazel?

oquenchil commented 1 year ago

An update on this, we will actually do it the other way around and make rules_cc the single copy instead of bazel_tools. Once I have merged all of Fabian's PRs, we can create a release.

keith commented 1 year ago

In that case we actually want to merge this one since the single copy of this is moving to apple_support

keith commented 1 year ago

@oquenchil can you help land this one?