search

bazelbuild / rules_cc

C++ Rules for Bazel
https://bazel.build
Apache License 2.0
181 stars 89 forks source link

Remove `//tools/runfiles` and add `//cc/runfiles` #162

Closed fmeum closed 1 year ago

fmeum commented 1 year ago

The targets in the old package were either not publicly visible or testonly dependencies and had diverged heavily from @bazel_tools.

Instead, add an alias to the Bazel-provided runfiles library under //cc/runfiles, following https://bazel.build/rules/deploying.

fmeum commented 1 year ago

@oquenchil import/copybara is failing. Happy to look into the failure, but I don't seem to be able to access the logs.

oquenchil commented 1 year ago

Hey Fabian, it looks like I'm going to have to do this change internally first. I will credit you with ORIGINAL_AUTHOR.

The problem is that the copybara scripts are internal because they contain internal paths. The error I'm seeing is that a move is being applied on a file that doesn't exist in the working directory (which makes sense because it has been deleted). So I have to delete the file and modify the copybara script in the same change.