search

bazelbuild / rules_cc

C++ Rules for Bazel
https://bazel.build
Apache License 2.0
189 stars 94 forks source link

Use full path for dirname and basename in osx_cc_wrapper.sh.tpl #275

Closed meteorcloudy closed 1 week ago

meteorcloudy commented 1 week ago

Context: https://github.com/bazelbuild/rules_rust/pull/2998

meteorcloudy commented 1 week ago

@keith

meteorcloudy commented 1 week ago

@keith I also noticed that apple_support is still using the template from @bazel_tools, can we migrate to use it from rules_cc? https://github.com/bazelbuild/apple_support/blob/27df79d278aac09e3d973b98af2553f0a569cba3/crosstool/osx_cc_configure.bzl#L163

meteorcloudy commented 1 week ago

Merged at https://github.com/bazelbuild/rules_cc/commit/475a3539c4cf6370b600a1ca423008bac0a01147

keith commented 1 week ago

yes once there's a release with this change we could change that one