Proposal: Improve cygwin and cmake compatibility

bazelbuild / rules_cc

C++ Rules for Bazel

https://bazel.build

Apache License 2.0

186 stars 93 forks source link

Proposal: Improve cygwin and cmake compatibility #36

Closed coreprocess closed 3 years ago

coreprocess commented 5 years ago

Handles C:\tools\msys64\usr\bin\bash.sh as well as C:\tools\cygwin\bin\bash.sh as BAZEL_SH. Generates proper tooling paths for Cygwin.

Adds .exe for CMake/Ninja compatibility.

hlopko commented 5 years ago

Thanks @core-process! I'm happy to accept this PR. What I'm still figuring out is how to add a test coverage for this.

What do you think about also adding this to Bazel (https://source.bazel.build/bazel/+/master:tools/cpp/windows_cc_configure.bzl;l=77?q=windows_cc_configure&ss=bazel)? Can you imagine anybody depending on the previous behavior?

coreprocess commented 5 years ago

@hlopko I'm pretty sure the change is okay. But I am not in the position to make such a decision because I lack the overall view of the project. Regarding test coverage: a small sample which depends on a CMake and/or Ninja external, build with MSys/MingW and Cygwin.