search

bazelbuild / rules_cc

C++ Rules for Bazel
https://bazel.build
Apache License 2.0
186 stars 93 forks source link

Update googletest to 1.10.0 #38

Closed hlopko closed 5 years ago

hlopko commented 5 years ago

@fweikert - shouldn't googletest be updated in the federation as well? It's only a development dependency of rules_cc, so I'm not sure.

@Yannic - FYI, so you don't duplicate work updating rules_cc.

fweikert commented 5 years ago

From a federation point of view the ideal process would look like this:

  1. Add the com_google_googletest() function to https://github.com/bazelbuild/bazel-federation/blob/master/third_party_repositories.bzl which contains the call to http_archive
  2. Update rules_cc to use the latest federation version and to call com_google_googletest() from within rules_cc_internal_deps()

That's not a good experience for the rule owners, though, and definitely something that the federation working group has to discuss. For now the best solution would be to continue with this PR.