search

bazelbuild / rules_cc

C++ Rules for Bazel
https://bazel.build
Apache License 2.0
186 stars 93 forks source link

Update cc_toolchain_config_lib.bzl for bazelbuild/bazel#10967 #72

Closed Yannic closed 1 year ago

Yannic commented 4 years ago

This mirrors the changes from bazelbuild/bazel#10967 into rules_cc.

Yannic commented 4 years ago

@oquenchil ptal

Yannic commented 4 years ago

@oquenchil Any updates on this?

nathaniel-brough commented 1 year ago

Is there something blocking this from being merged? It's been open for 2+yrs now and it is quite a useful addition for toolchain maintainers.

oquenchil commented 1 year ago

copybara should have merged, I will try again. @Yannic could you please sync?

nathaniel-brough commented 1 year ago

I don't want to hijack the PR. But I've got a synced version here https://github.com/silvergasp/rules_cc/tree/patch-2 @Yannic would you accept a PR with the synced changes?

oquenchil commented 1 year ago

Synced version already merged.