search

bazelbuild / rules_cc

C++ Rules for Bazel
https://bazel.build
Apache License 2.0
182 stars 90 forks source link

Buildifier warns about lack of rules_cc; rules_cc says you don't have to use it #92

Closed GMNGeoffrey closed 1 year ago

GMNGeoffrey commented 3 years ago

native-cc: Function "cc_library" is not global anymore and needs to be loaded from "@rules_cc//cc:defs.bzl". (https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md#native-cc)

There is no need to use rules from this repository just yet. If you want to use rules_cc anyway, add the following to your WORKSPACE file https://github.com/bazelbuild/rules_cc#getting-started

These are clearly not compatible. In addition, the instruction to add rules_cc to your WORKSPACE file seem to be not accurate based on https://github.com/bazelbuild/bazel/issues/8743#issuecomment-704209848.

Please make the tools in the ecosystem and their documentation consistent.

Cross-posted as https://github.com/bazelbuild/buildtools/issues/923

keith commented 3 years ago

related https://github.com/bazelbuild/rules_cc/issues/86

limdor commented 1 year ago

I would propose to close this issue. Buildifier is no longer asking for loading rules_cc

GMNGeoffrey commented 1 year ago

Agreed. The corresponding Buildozer issue (https://github.com/bazelbuild/buildtools/issues/923) was fixed in https://github.com/bazelbuild/buildtools/pull/952