search

bazelbuild / rules_cc

C++ Rules for Bazel
https://bazel.build
Apache License 2.0
182 stars 90 forks source link

Add example of creating and invoking a custom C++ toolchain #98

Closed gregestren closed 3 years ago

gregestren commented 3 years ago

Inspired by https://github.com/bazelbuild/bazel/issues/12942.

Staging: https://github.com/gregestren/rules_cc/tree/master/examples/custom_toolchain

gregestren commented 3 years ago

CC @katre

gregestren commented 3 years ago

@oquenchil only code owners can merge. Could you merge?

Re: the failing presubmit, that's buildifiier's "print: "print()" is a debug function and shouldn't be submitted.". But since this is demo code this is intentional in this case.

oquenchil commented 3 years ago

This cannot be merged manually. A change is created in Gerrit and then I have to LGTM there. After that, there is a change created internally and that has to be approved again by somebody else. I lgtm'd on Gerrit but it says there is a merge conflict.