Possibly updating Closure Library to `v20210601`? :)

bazelbuild / rules_closure

Closure rules for Bazel

https://developers.google.com/closure

Apache License 2.0

153 stars 114 forks source link

Possibly updating Closure Library to `v20210601`? :) #528

Closed sampajano closed 2 years ago

sampajano commented 3 years ago

We have a recent change in https://github.com/grpc/grpc-web which requires the newest version of closure library (v20210601). I wonder how much effort would it be for rules_closure to upgrade to it (current version is 20191027 if i'm reading correctly? :)) Thanks a lot in advance! :)

gkdn commented 3 years ago

The main issue is https://github.com/bazelbuild/rules_closure/issues/516

To be honest, I don't know the effort required since I don't know all the implications of goog.requireType and have not spent much time around the script that generates the BUILD targets .

Being said that; that issue needs to be resolved one way or the other for going forward.

sampajano commented 3 years ago

Thanks so much for the context, Goktug! I'll follow-up with you on #516 :)

@Yannic Hey Yannic! Cc'ing you here because @stanley-cheung has mentioned you've helped with similar issues in the past.. and in case you have some ideas too :)