bazelbuild / rules_closure

Closure rules for Bazel
https://developers.google.com/closure
Apache License 2.0
153 stars 114 forks source link

Consume closure library from HEAD #536

Closed pcj closed 2 years ago

pcj commented 3 years ago

This PR is a draft, it's not been tested thoroughly outside of an internal repository but I am using this PR commit successfully there.

The patch of closure library sources is excessive and was done quickly via:

$ bazel query @com_google_javascript_closure_library//closure/goog/... > labels.txt

And then iteratively recompiling, adding suppressions via:

$ cat labels.txt | xargs buildozer -types closure_js_library 'add suppress JSC_DEPRECATED_CLASS_REASON'

A more targeted buildozer script would be preferable.

A few manual changes were made also such as https://github.com/google/closure-library/issues/1147.