search

bazelbuild / rules_closure

Closure rules for Bazel
https://developers.google.com/closure
Apache License 2.0
152 stars 114 forks source link

rules_closure Testcases are failing with Bazel@HEAD #595

Closed sgowroji closed 9 months ago

sgowroji commented 10 months ago

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3428#018b88a0-6d0a-4feb-a06b-8ca6679372b4

Platform : Macos, Ubuntu

Logs:

FAIL: //closure/protobuf/test:foo_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/protobuf/test/foo_test/test_attempts/attempt_1.log)
(03:07:33) FAIL: //closure/compiler/test/goog_es6_interop:person_factory_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/compiler/test/goog_es6_interop/person_factory_test/test_attempts/attempt_1.log)
(03:07:33) FAIL: //closure/testing/test:dict_entry_point_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/testing/test/dict_entry_point_test/test_attempts/attempt_1.log)
(03:07:33) FAIL: //closure/templates/test:greeter_proto_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/templates/test/greeter_proto_test/test_attempts/attempt_1.log)
(03:07:33) FAIL: //closure/testing/test:arithmetic_es6module_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/testing/test/arithmetic_es6module_test/test_attempts/attempt_1.log)
(03:07:33) FAIL: //closure/testing/test:arithmetic_scope_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/testing/test/arithmetic_scope_test/test_attempts/attempt_1.log)
(03:07:33) FAIL: //closure/templates/test:globals_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/templates/test/globals_test/test_attempts/attempt_1.log)
(03:07:33) FAIL: //closure/testing/test:lenient_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/testing/test/lenient_test/test_attempts/attempt_1.log)
(03:07:33) FAIL: //closure/protobuf/test:baz_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/protobuf/test/baz_test/test_attempts/attempt_1.log)
(03:07:33) FAIL: //closure/testing/test:arithmetic_module_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/testing/test/arithmetic_module_test/test_attempts/attempt_1.log)
(03:07:33) FAIL: //closure/protobuf/test/legacy:example_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/protobuf/test/legacy/example_test/test_attempts/attempt_1.log)
(03:07:33) FAIL: //closure/templates/test:greeter_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/templates/test/greeter_test/test_attempts/attempt_1.log)
(03:07:33) FAIL: //closure/protobuf/test:bat_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/protobuf/test/bat_test/test_attempts/attempt_1.log)
(03:07:33) FAIL: //closure/testing/test:simple_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/testing/test/simple_test/test_attempts/attempt_1.log)
(03:07:33) FAIL: //closure/testing/test:dom_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/testing/test/dom_test/test_attempts/attempt_1.log)
(03:07:33) FAIL: //closure/testing/test:arithmetic_es6module_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/testing/test/arithmetic_es6module_test/test_attempts/attempt_2.log)
(03:07:33) FAIL: //closure/protobuf/test:foo_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/protobuf/test/foo_test/test_attempts/attempt_2.log)
(03:07:33) FAIL: //closure/compiler/test/goog_es6_interop:person_factory_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/compiler/test/goog_es6_interop/person_factory_test/test_attempts/attempt_2.log)
(03:07:34) FAIL: //closure/testing/test:lenient_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/testing/test/lenient_test/test_attempts/attempt_2.log)
(03:07:34) FAIL: //closure/templates/test:greeter_proto_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/templates/test/greeter_proto_test/test_attempts/attempt_2.log)
(03:07:34) FAIL: //closure/protobuf/test:baz_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/protobuf/test/baz_test/test_attempts/attempt_2.log)
(03:07:34) FAIL: //closure/testing/test:arithmetic_scope_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/testing/test/arithmetic_scope_test/test_attempts/attempt_2.log)
(03:07:34) FAIL: //closure/protobuf/test/legacy:example_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/protobuf/test/legacy/example_test/test_attempts/attempt_2.log)
(03:07:34) FAIL: //closure/testing/test:arithmetic_module_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/testing/test/arithmetic_module_test/test_attempts/attempt_2.log)
(03:07:34) FAIL: //closure/templates/test:greeter_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/templates/test/greeter_test/test_attempts/attempt_2.log)
(03:07:34) FAIL: //closure/testing/test:simple_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/testing/test/simple_test/test_attempts/attempt_2.log)
(03:07:34) FAIL: //closure/protobuf/test:bat_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/protobuf/test/bat_test/test_attempts/attempt_2.log)
(03:07:34) FAIL: //closure/testing/test:dict_entry_point_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/testing/test/dict_entry_point_test/test_attempts/attempt_2.log)
(03:07:34) FAIL: //closure/templates/test:globals_test (see /private/var/tmp/_bazel_buildkite/cc47fe2e3cb1befe8a7dc3d1b30e7228/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/closure/templates/test/globals_test/test_attempts/attempt_2.log)
(03:07:34) FAIL: //closure/testing/test:arithmetic_es6module_test

Steps:

git clone https://github.com/bazelbuild/rules_closure.git
git reset f19dc96c1dad6990b67dc3a35818cde5b7042bbb --hard
export USE_BAZEL_VERSION=206bec1ee2309ef64309fc3eb1c35576f7f6c37c
bazel test ...

Culprit : a3f0bfa99ccc722e90a69d34e7efb385e7ed749d

CC greenteam @comius

gkdn commented 10 months ago

@mollyibot

mollyibot commented 10 months ago

Taking a look..

mollyibot commented 10 months ago

I did a bit of investigation and find the runtime folder does not contains phantomjs related files in the runtime folder. here is the error message:

/usr/local/google/home/mollyibot/.cache/bazel/_bazel_mollyibot/c5fd8bb81ccbc5ab205975b5404e8570/sandbox/linux-sandbox/2010/execroot/_main/bazel-out/k8-fastbuild/bin/closure/testing/test/simple_test.runfiles/_main/third_party/phantomjs/phantomjs: line 39: /usr/local/google/home/mollyibot/.cache/bazel/_bazel_mollyibot/c5fd8bb81ccbc5ab205975b5404e8570/sandbox/linux-sandbox/2010/execroot/_main/bazel-out/k8-fastbuild/bin/closure/testing/test/simple_test.runfiles/_main/../io_bazel_rules_closure/third_party/phantomjs/bin/phantomjs: No such file or directory

Did binary search and find a culprit https://github.com/bazelbuild/bazel/commit/30d033cd7e2153e8b8d7eb034a5323053192ecaa. I think after this commit Bzlmod is enabled by default, there is a subtle impact on our external dependencies, need to investigate a bit more.

mollyibot commented 10 months ago

we can addalways --noenable_bzlmod in the .bazelrc.

sgowroji commented 10 months ago

Hi @mollyibot, Any update on the Testcase failures?

mollyibot commented 10 months ago

I created another pull request here https://github.com/bazelbuild/rules_closure/pull/597

Wyverald commented 9 months ago

This is fixed.