Plumb through support for CPU variant - Githubissues

bazelbuild / rules_docker

Rules for building and handling Docker images with Bazel

Apache License 2.0

1.07k stars 694 forks source link

Plumb through support for CPU variant #2228

Open bdhess opened 1 year ago

bdhess commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

[X] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) - incomplete - not sure what doc update would be appropriate

PR Type

What kind of change does this PR introduce?

[x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

container_image rules always replace the CPU architecture with "amd64" and the CPU variant with an empty string in emitted config json.

Issue Number: N/A

What is the new behavior?

Architecture and variant are copied from the base image.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

N/A

github-actions[bot] commented 1 year ago

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!