bazelbuild / rules_docker

Rules for building and handling Docker images with Bazel
Apache License 2.0
1.07k stars 694 forks source link

Expand location templates in container_run_and_extract rule. #2235

Open k0walik opened 1 year ago

k0walik commented 1 year ago

The container_run_and_extract rule accepts list of labels as the input arguments passed to the action running the container. We could elevate this information by applying expand_templates to docker_run_flags and pass generated files (i.e. environmental variables) as the input to the shell script that executes the action.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Location templates in docker_run_flags are passed to docker run commands as literal strings.

Issue Number: N/A

What is the new behavior?

Expand location templates before expanding shell script templates, so the paths to generated files are passed correctly.

Does this PR introduce a breaking change?

Other information

github-actions[bot] commented 1 year ago

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!