bazelbuild / rules_docker

Rules for building and handling Docker images with Bazel
Apache License 2.0
1.07k stars 692 forks source link

Revert "Update providers.bzl (#2077)" #2249

Open jacobmou opened 1 year ago

jacobmou commented 1 year ago

This reverts commit 0768e1b7f6aa973f9879ac5b8f622dd2f3d88f1d.

In the original patch https://github.com/bazelbuild/rules_docker/pull/2077, tag and stamp_input fields of PushInfo were removed with the assumption that they become obsolete since bazel 5.0. However, bazel itself doesn't control our customized PushInfo provider. And we have been using them with bazel 5.3 with no issues.

We have some downstream rules that are relying on these field and would like to keep using them in latest version of rules_docker.

@philsc for vis.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Other information