bazelbuild / rules_docker

Rules for building and handling Docker images with Bazel
Apache License 2.0
1.07k stars 694 forks source link

Add gazelle rule for bzl_library #2260

Closed rysteboe closed 1 year ago

rysteboe commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Currently, there are either no bzl_library targets defined for .bzl files or the ones that exist are private. This is problematic for downstream users who wish to generate stardoc.

What is the new behavior?

Adds the bzl gazelle rule while will automatically generate these targets. It also removed the private visibility from the existing targets, as I don't believe there's a reason to keep those private (their underlying .bzl files are all public).

Does this PR introduce a breaking change?

Other information

This would be a big QoL improvement - right now it is actually impossible for my team to use stardoc based on the nodejs package since it doesn't load any bzl files. I know this repo isn't really maintained but a few of us still use it!