Please check if your PR fulfills the following requirements:
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
What is the current behavior?
The current implementation of dockerfile_build rule looks up for environment variables value and uses None as fallback value for undefined one. This causes to resolve into --build-arg <ENV_VAR>=None build argument, which is interpreted as valid, defined value.
What is the new behavior?
Instead, we should fallback to empty string for undefined environment variables, which resolves to --build-arg <ENV_VAR>='' and is interpreted as empty value. This would match the same output as produced in shell:
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The current implementation of dockerfile_build rule looks up for environment variables value and uses
Noneas fallback value for undefined one. This causes to resolve into--build-arg <ENV_VAR>=Nonebuild argument, which is interpreted as valid, defined value.What is the new behavior?
Instead, we should fallback to empty string for undefined environment variables, which resolves to
--build-arg <ENV_VAR>=''and is interpreted as empty value. This would match the same output as produced in shell:Does this PR introduce a breaking change?
Other information