search

bazelbuild / rules_foreign_cc

Build rules for interfacing with "foreign" (non-Bazel) build systems (CMake, configure-make, GNU Make, boost, ninja, Meson)
https://bazelbuild.github.io/rules_foreign_cc
Apache License 2.0
649 stars 232 forks source link

Fix `//openssl/...` by calling `openssl_setup()` #1137

Closed bcsgh closed 6 months ago

bcsgh commented 6 months ago

This is the proximate cause that resulted in https://github.com/bazelbuild/rules_foreign_cc/issues/1135

bcsgh commented 6 months ago

I looks like the failing checks are failing at HEAD?

bcsgh commented 6 months ago

Until WORKSPACE support is removed (as in can't be turned on) from all still supported version of bazel, keeping official examples working that way should be (IMHO) an official goal.

Sure people should move over, but if you push too hard on that, some people will see switching to a build tool that is less demanding about its opinions start looking just as easy in the short term and less hassle in the long run. In my case, if I'd know how much I'd need to fix I'd likely have deferred upgrading to 7.0.0 for another 2-3 months and there definitely isn't room in the project's calendar to switch to MODULE.bazel until then.