search

bazelbuild / rules_foreign_cc

Build rules for interfacing with "foreign" (non-Bazel) build systems (CMake, configure-make, GNU Make, boost, ninja, Meson)
https://bazelbuild.github.io/rules_foreign_cc
Apache License 2.0
650 stars 232 forks source link

[Bazel CI] Fix(build): Declare 'j2objc' as a required fragment for 'apple_binary' in 'rules_foreign_cc_examples_third_party//cares' #1183

Closed sgowroji closed 3 months ago

sgowroji commented 3 months ago

CI: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3720#018e4049-e53e-4b45-ac0c-5df586255e14

Platform: MacOS

Logs: 

ERROR: /private/var/tmp/_bazel_buildkite/f87e1b5afd3bd480237d7401eee51540/external/rules_foreign_cc_examples_third_party/cares/BUILD.bazel:19:13: in apple_binary rule @@rules_foreign_cc_examples_third_party//cares:ios_binary: 
Error: apple_binary has to declare 'j2objc' as a required fragment in order to access it. Please update the 'fragments' argument of the rule definition (for example: fragments = ["j2objc"])
ERROR: /private/var/tmp/_bazel_buildkite/f87e1b5afd3bd480237d7401eee51540/external/rules_foreign_cc_examples_third_party/cares/BUILD.bazel:19:13: Analysis of target '@@rules_foreign_cc_examples_third_party//cares:ios_binary' failed
ERROR: Analysis of target '@@rules_foreign_cc_examples_third_party//cares:test_c_ares_ios' failed; build aborted: Analysis failed
ERROR: Build did NOT complete successfully
FAILED: 
FAILED: 
Error: The command exited with status 1
error: exit status 1

Culprit:

Steps:

 git clone https://github.com/bazelbuild/rules_foreign_cc
git reset 86936d7b5b6022eba654fee1b0937915159e94ba  --hard
export USE_BAZEL_VERSION=6f254ce0f95d70e744b513a94d577036712befac
bazel build //... //:third_party_examples_macos_tests -//cmake_android/... -@rules_foreign_cc_examples_third_party//curl:curl_test -@rules_foreign_cc_examples_third_party//openssl:openssl_test

CC Greenteam @wyverald

sgowroji commented 3 months ago

Similar issue #1174

sgowroji commented 3 months ago

CC  @UebelAndre,  @jsharpe , @irengrig Can you take a look on the above failures. Thanks!

sgowroji commented 3 months ago

We are moving rules_foreign_cc to disable pipeline, As it is stale from long time.

meteorcloudy commented 3 months ago

Did we try to upgrade apple rules for rules_foreign_cc?

sgowroji commented 3 months ago

Updated now #1190