search

bazelbuild / rules_fuzzing

Bazel Starlark extensions for defining fuzz tests in Bazel projects
Apache License 2.0
82 stars 19 forks source link

Use correct `cc_engine_instrumentation` in `jazzer` config #158

Closed fmeum closed 3 years ago

fmeum commented 3 years ago

While the cc_engine_instrumentation settings libfuzzer and jazzer lead to the same instrumentation, this may not remain so indefinitely. Thus the jazzer and asan-jazzer config in .bazelrc should use the jazzer value for the setting.

Also, even when not using a sanitizer via the jazzer config, native library dependencies should be instrumented for fuzzing.

This requires updating Jazzer to the latest version as previous versions did not correctly export certain sanitizer symbols.

fmeum commented 3 years ago

Not sure why this issue has only appeared now, but it will be resolved by the extended logic for populating LD_LIBRARY_PATH in #157. This one can wait until the PR has been merged.

stefanbucur commented 3 years ago

Not sure why this issue has only appeared now, but it will be resolved by the extended logic for populating LD_LIBRARY_PATH in #157. This one can wait until the PR has been merged.

This PR looks good to me, will approve and merge once #157 lands.

fmeum commented 3 years ago

The checks pass now.