search

bazelbuild / rules_go

Go rules for Bazel
Apache License 2.0
1.35k stars 635 forks source link

Revert "feat(mode): add `purego` tag when `pure` (#3901)" #3961

Closed fmeum closed 1 week ago

fmeum commented 2 weeks ago

This reverts commit fcd6390936ac61d76b5c00f1f33a505045d11888.

purego regresses performance of certain third-party libraries (see https://github.com/bazelbuild/rules_go/issues/3959).

Work towards #3959

fmeum commented 2 weeks ago

@tyler-french We should probably do a patch release v0.48.1 based on v0.48.0 with just this revert cherry-picked on top. What do you think?

tyler-french commented 1 week ago

@tyler-french We should probably do a patch release v0.48.1 based on v0.48.0 with just this revert cherry-picked on top. What do you think?

Sounds good