search

bazelbuild / rules_groovy

Groovy rules for Bazel
Apache License 2.0
11 stars 28 forks source link

Groovy SDK and Spock core library versions are outdated #38

Closed bmuschko closed 4 years ago

bmuschko commented 5 years ago

At the moment the following versions are used:

It would be a good idea to move to a newer version by default. I'd be happy to send a pull request. Let me know what you think.

ekuefler commented 5 years ago

Updating the defaults sounds good - would be great if you wanted to send a PR for it!

bmuschko commented 5 years ago

Sure, I am planning to work on a PR in the next couple of days.

bmuschko commented 5 years ago

Sent PR https://github.com/bazelbuild/rules_groovy/pull/42

bmuschko commented 4 years ago

This is somewhat of a moving target. For example, Groovy 2.5.9 has been released in the meantime. Do you have ideas around maintaining newer versions going forward or are you relying on the community to provide PRs for this?

bmuschko commented 4 years ago

For now I am going to close this issue as the original request has been fixed. Let me know what you think though.

ekuefler commented 4 years ago

Yeah, I don't know of a better option here than just sending PRs when a new version comes out. Note that these are just the defaults, so updates here shouldn't block anyone since it's always possible to specify a newer version manually.

bmuschko commented 4 years ago

@ekuefler Will do. Do you have example code that shows how to reconfigure the default version of a library? A code snippet here should do as well.