search

bazelbuild / rules_gwt

Bazel rules for GWT
Apache License 2.0
19 stars 14 forks source link

Please move from native to Skylark rules for external git/http repositories #15

Closed aehlig closed 5 years ago

aehlig commented 6 years ago

Bazel is planning to move away from native rules for external repositories to Skylark rules, mainly because bundling every version control system in bazel does not scale. As part of this effort, we plan to submit https://bazel-review.googlesource.com/c/bazel/+/55932 soon, which will cause bazel by default to insist that the skylark versions the git and http rules for external repositories be used. This can be disabled by a flag for at least the next 6 months, but we still would appreciate if you could adopt your repository to use the Skylark versions of those rules soon.

A test run of downstream projects with that flag flip in bazel enabled can be found at https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/286

For more background, see

Thanks.

ekuefler commented 6 years ago

Hi Klaus - could you give me access to the project on buildkite? Also, is there a way for me to check on the current version of Bazel whether I've done the fix correctly? When I run bazel build --incompatible_remove_native_http_archive ... locally in this repo I don't see any errors.

aehlig commented 6 years ago

For buildkite access, you would have to ask @buchgr or @philwo. But if running bazel build --all_incompatible_changes ... works, things are fine. Thanks.

buchgr commented 6 years ago

@ekuefler invite sent to your @google.com

hlopko commented 5 years ago

Hi all, this flag is flipped now at bazel@HEAD and will be the default behavior of Bazel 0.20. I'll disable this project on our downstream pipeline (https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/531#c09b9129-338b-48ad-b55b-db5c6874483a). Please fix quickly and create an issue at bazelbuild/continuous-integration to reenable. Keep in mind that we are not catching unintentional breakages of this project in bazel@HEAD.

meteorcloudy commented 5 years ago

@ekuefler You'll have to update here https://github.com/bazelbuild/rules_gwt/blob/e5e8f4f1675aaf9ff25a0b8c06d2a66ecdc87ac3/gwt/gwt.bzl#L336-L340 with 

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_jar")