search

bazelbuild / rules_java

Java rules for Bazel
Apache License 2.0
70 stars 63 forks source link

Provide a way of packaging separate layers into Java container after deprecation of rules_docker #160

Open C0mbatwombat opened 9 months ago

C0mbatwombat commented 9 months ago

(It feels awkward to ask this question here, but it is a follow-up of this suggestion over at rules_oci )

As the maintainers have decided that the rules_oci repository should remain language agnostic, it is quite unclear where to go with questions for language-specific containers, so following @alexeagle 's advice I am trying over here.

I would like to migrate from rules_docker to rules_oci, but the functionality to package depsets into separate layers has not been provided by the new rules (_jar_app_layer_impl ).

Would it be possible to provide similar functionality in a .defs file in this repository, and could someone help me out in porting it?

SanjayVas commented 9 months ago

Related logic from rules_java (once these parts are actually migrated to Starlark) that was replicated in jar_app_layer was handling runfiles and native libraries.

C0mbatwombat commented 9 months ago

Hi @SanjayVas thanks for your reply, do I understand correctly that you are planning to migrate the functionality to rules_java?

SanjayVas commented 8 months ago

do I understand correctly that you are planning to migrate the functionality to rules_java?

No. I'm not a contributor to rules_java. I'm just sharing some context for why this likely needs to be solved in rules_java instead of downstream.